bpo-40939: Remove the old parser by pablogsal · Pull Request #20768 · python/cpython

the-knights-who-say-ni

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is also a note in Doc/using/cmdline.rst that will need to be removed.

Hi, there is also a note in Doc/using/cmdline.rst that will need to be removed.

Thanks for the catch!

pablogsal marked this pull request as ready for review

June 10, 2020 11:25

pablogsal changed the title ~~Remove the old parser~~ bpo-40939: Remove the old parser

Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Amazing work, I couldn't find a single miss! 🚀

Also, I guess this is what we've been really working for in the last months. Feels good!

I plan to land this tomorrow as this PR keeps getting merge conflicts from everywhere and it will be easier to fix small things in future PRs if needed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this file deleted?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is comparing the ast of the old parser to the last of the new parser, so it serves no purpose anymore. We have been adding all negative cases (testing extensions) into other files so we won't lose anything

I have rebased again to solve more merge conflicts. Could you review again?

Update cmdline.rst

📜🤖 Added by blurb_it.

Clean some tests and bring back some deleted cases

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could backport the file renames? (Not the moves from Parser/pegen/* to Parser/*, but the rename of parse.c to parser.c and parse_string.c to string_parser.c.)

I wonder if we could backport the file renames? (Not the moves from Parser/pegen/* to Parser/*, but the rename of parse.c to parser.c and parse_string.c to string_parser.c.)

👍 I will try to make a PR later today with that