◐ Shell
clean mode source ↗

bpo-40950: Port nis module to multiphase initialization by corona10 · Pull Request #20811 · python/cpython

the-knights-who-say-ni

Conversation

@corona10

@corona10 corona10 commented

Jun 11, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

corona10 and others added 2 commits

June 12, 2020 01:08

@corona10 corona10 requested a review from vstinner

June 11, 2020 16:16

@corona10 corona10 left a comment

Copy link Copy Markdown

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner
Thanks for the review!
Updated!
Comment thread

Modules/nismodule.c Outdated

Comment thread

Modules/nismodule.c Outdated

@corona10 corona10 requested a review from vstinner

June 11, 2020 17:43

@corona10

Copy link Copy Markdown

Member Author

@shihai1991 Can you please take a look?

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corona10 corona10 changed the title bpo-40950: Apply PEP 3121 to nis module bpo-40950: Port nis module to multiphase initialization

Jun 12, 2020

@corona10 corona10 merged commit ddef3bd into python:master

Jun 12, 2020

@corona10 corona10 deleted the bpo-40950 branch

June 13, 2020 01:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shihai1991 shihai1991 shihai1991 left review comments

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10 @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot