◐ Shell
clean mode source ↗

bpo-40959: Remove unused and unneeded declarations from sqlite3 headers by erlend-aasland · Pull Request #20828 · python/cpython

@erlend-aasland

@berkerpeksag If you feel I'm flooding you with PR's/code reviewing, please let me know. Also, I might have missed a point or two in the devs guide, so if I'm proceeding with PR's/issues in a totally incorrect matter, feel free to point me in the right direction.

@erlend-aasland

@erlend-aasland

@corona10 would you mind reviewing this? It's a straight-forward cleanup of the _sqlite3 header files:

  • remove function declarations for functions that are not used by other .c files
  • remove function declarations for functions that don't exist anymore

Diffstat:

 Modules/_sqlite/cache.h            |  5 -----
 Modules/_sqlite/connection.h       |  7 -------
 Modules/_sqlite/cursor.h           | 10 ----------
 Modules/_sqlite/prepare_protocol.h |  3 ---
 Modules/_sqlite/statement.h        |  1 -
 5 files changed, 26 deletions(-)

berkerpeksag

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you please fix merge conflicts?

@erlend-aasland

LGTM! Could you please fix merge conflicts?

Sure. 2 sec...

berkerpeksag

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021