bpo-35975: Only use cf_feature_version if PyCF_ONLY_AST in cf_flags by gvanrossum · Pull Request #21021 · python/cpython
Conversation
Stefan Behnel reported that cf_feature_version is used even when
PyCF_ONLY_AST is not set. This is against the intention and against the
documented behavior, so it's been fixed. Includes a test contributed by Stefan.
I've done manual backports -- should I keep the "needs backport to XXX" labels or ditch them?
I've done manual backports -- should I keep the "needs backport to XXX" labels or ditch them?
Let's remove them, because if not the bots will create PRs on merge
| @@ -0,0 +1,3 @@ | |||
| Stefan Behnel reported that cf_feature_version is used even when | |||
| PyCF_ONLY_AST is not set. This is against the intention and against the | |||
| documented behavior, so I fixed it. | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to avoid "I" in the NEWS entry? At least, replace it with Guido. Otherwise, it's unclear who is "I".
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change this to "so it's been fixed."
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :-)
@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!
