◐ Shell
clean mode source ↗

[3.9] bpo-40939: Do not emit deprecation warnings inside CPython for old parser APIs by pablogsal · Pull Request #21025 · python/cpython

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

lysnikolaou

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with diagnostic pragmas, so I'm not the most suited to review this.

@nnemkin

Consider doing this instead (in the header file):

#ifndef Py_BUILD_CODE
Py_DEPRECATED(3.9)
#endif
PyAPI_FUNC(struct _node *) PyParser_...

@pablogsal

Consider doing this instead (in the header file):

Good point!

Labels