◐ Shell
clean mode source ↗

gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing by asottile · Pull Request #21104 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@asottile

@asottile asottile commented

Jun 24, 2020

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

@asottile asottile force-pushed the inspect_signature_simplify branch from 5309efa to 847fd9f Compare

September 3, 2020 18:10

@asottile asottile force-pushed the inspect_signature_simplify branch from 847fd9f to e569169 Compare

November 2, 2021 02:24

@asottile asottile force-pushed the inspect_signature_simplify branch from e569169 to 477c2eb Compare

July 8, 2022 16:27

@asottile asottile force-pushed the inspect_signature_simplify branch from 477c2eb to 83f9192 Compare

August 5, 2022 20:22

@asottile

Copy link Copy Markdown

Contributor Author

@1st1 (inspect expert) -- been sitting on this small fix for a few years -- any chance of a review ?

@asottile asottile force-pushed the inspect_signature_simplify branch from 83f9192 to e6eaf8e Compare

October 5, 2022 21:16

@iritkatriel iritkatriel changed the title Simplify routine in inspect.signature parsing remove unused 'invalid' variable in inspect.signature parsing

Nov 27, 2022

@iritkatriel iritkatriel changed the title remove unused 'invalid' variable in inspect.signature parsing remove unused 'invalid' value in inspect.signature parsing

Nov 27, 2022

@iritkatriel iritkatriel changed the title remove unused 'invalid' value in inspect.signature parsing gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing

Nov 27, 2022

@iritkatriel iritkatriel merged commit ac115b5 into python:main

Nov 27, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@asottile @iritkatriel @eamanu @the-knights-who-say-ni @ezio-melotti @bedevere-bot @kumaraditya303