bpo-41521, typing: Rename _PROTO_WHITELIST to _PROTO_ALLOWLIST by vstinner · Pull Request #21825 · python/cpython
Merged
Conversation
- Would you mind to review this change?
- Is it ok to rename the private
typing._PROTO_WHITELISTvariable? - Should we keep an alias (
_PROTO_WHITELIST = _PROTO_ALLOWLIST) during 1 or 2 releases? - Should I document this change change in a NEWS entry?
FYI I also renamed one test_typing test in commit 0ee0b29.
I prefer not to do this. I find it linguistically awkward, and reading the history of “blacklist” on Wikipedia I don’t see any connection with racism. en.m.wikipedia.org/wiki/Blacklisting
Yes, the term is not racist. It's more subtle. The negative co-notation of black is death by a thousand paper cuts. The great Muhammad Ali explained this in multiple interviews, e.g. https://www.youtube.com/watch?v=7eXdt1eGgCA
@ambv: Please replace # with GH- in the commit message next time. Thanks!
YouJiacheng added a commit to YouJiacheng/typing_extensions that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters