◐ Shell
clean mode source ↗

bpo-41521, typing: Rename _PROTO_WHITELIST to _PROTO_ALLOWLIST by vstinner · Pull Request #21825 · python/cpython

Merged

ambv

merged 1 commit into

Aug 12, 2020

Conversation

@vstinner

@gvanrossum @ilevkivskyi:

  • Would you mind to review this change?
  • Is it ok to rename the private typing._PROTO_WHITELIST variable?
  • Should we keep an alias (_PROTO_WHITELIST = _PROTO_ALLOWLIST) during 1 or 2 releases?
  • Should I document this change change in a NEWS entry?

@vstinner

FYI I also renamed one test_typing test in commit 0ee0b29.

@gvanrossum

@tiran

I prefer not to do this. I find it linguistically awkward, and reading the history of “blacklist” on Wikipedia I don’t see any connection with racism. en.m.wikipedia.org/wiki/Blacklisting

Yes, the term is not racist. It's more subtle. The negative co-notation of black is death by a thousand paper cuts. The great Muhammad Ali explained this in multiple interviews, e.g. https://www.youtube.com/watch?v=7eXdt1eGgCA

@gvanrossum

Then someone else can approve this. I hope you understand.

@bedevere-bot

@ambv: Please replace # with GH- in the commit message next time. Thanks!

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request

Aug 20, 2020

xzy3 pushed a commit to xzy3/cpython that referenced this pull request

Oct 18, 2020

YouJiacheng added a commit to YouJiacheng/typing_extensions that referenced this pull request

Mar 28, 2023

Labels