bpo-1635741: port blake2 module to multi-phase init by koubaa · Pull Request #21856 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Merged
Conversation
Contributor
koubaa added 5 commits
d282ca9 to
abb51fe
Compare
= and others added 4 commits
koubaa
commented
Aug 29, 2020
koubaa commented
Contributor Author
@vstinner @shihai1991 This is ready for review
vstinner
reviewed
Modules/_blake2/blake2b_impl.c Outdated
Modules/_blake2/blake2module.c Outdated
Modules/_blake2/blake2module.c Outdated
Modules/_blake2/blake2module.c Outdated
Modules/_blake2/blake2s_impl.c Outdated
vstinner
approved these changes
vstinner
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a minor suggestion on the NEWS entry (please update it).
But right now, I cannot merge the PR: https://mail.python.org/archives/list/python-dev@python.org/thread/KMXK6BQWQZRR2TGVRLECMR7CUVIVTUMQ/
Please ping me when the workflow will be repaired, so I will merge your PR.
Misc/NEWS.d/next/Core and Builtins/2020-08-13-07-18-05.bpo-1635741.FC13e7.rst Outdated
koubaa
commented
Sep 1, 2020
koubaa commented
Contributor Author
@vstinner looks like the doc issue is fixed in the CI.
a7f0268
into
python:master
vstinner
commented
Sep 2, 2020
vstinner commented
Member
Merged, thanks @koubaa.
xzy3 pushed a commit to xzy3/cpython that referenced this pull request
Port the _blake2 extension module to the multi-phase initialization API (PEP 489).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
