[doc] Add link to FileHandler in logging (GH-21940) by andresdelfino · Pull Request #21940 · python/cpython
No link exists in the doc
Automerge-Triggered-By: @vsajip
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table contains numerous other references to FileHandler and StreamHandler - I would suggest changing them all to cross-references, or leaving them all as is.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
Thanks for reviewing, @vsajip I have made the requested changes; please review again
Thanks for making the requested changes!
@vsajip: please review the changes made to this pull request.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently there are conflicts - please resolve.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
Thanks for making the requested changes!
@vsajip: please review the changes made to this pull request.
For some reason, make -C Doc/ PYTHON=../python SPHINXOPTS="-q -W --keep-going -j4" doctest suspicious html is not using the created venv.
make htmlview works correctly locally.
vsajip
changed the title
[doc] Add link to FileHandler in logging
[doc] Add link to FileHandler in logging (GH-21940)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request
Co-authored-by: Andrés Delfino <adelfino@onapsis.com>