◐ Shell
clean mode source ↗

bpo-39010: Fix errors logged on proactor loop restart by bdarnell · Pull Request #22017 · python/cpython

Stopping and restarting a proactor event loop on windows can lead to
spurious errors logged (ConnectionResetError while reading from the
self pipe). This fixes the issue by ensuring that we don't attempt
to start multiple copies of the self-pipe reading loop.

1st1

1st1 approved these changes Aug 31, 2020

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 31, 2020
Stopping and restarting a proactor event loop on windows can lead to
spurious errors logged (ConnectionResetError while reading from the
self pipe). This fixes the issue by ensuring that we don't attempt
to start multiple copies of the self-pipe reading loop.
(cherry picked from commit ea5a636)

Co-authored-by: Ben Darnell <ben@bendarnell.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 31, 2020
Stopping and restarting a proactor event loop on windows can lead to
spurious errors logged (ConnectionResetError while reading from the
self pipe). This fixes the issue by ensuring that we don't attempt
to start multiple copies of the self-pipe reading loop.
(cherry picked from commit ea5a636)

Co-authored-by: Ben Darnell <ben@bendarnell.com>

bdarnell added a commit to bdarnell/cpython that referenced this pull request

Sep 2, 2020
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.

Follow-up to pythonGH-22017

1st1 pushed a commit that referenced this pull request

Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.

Follow-up to GH-22017

1st1 pushed a commit that referenced this pull request

Sep 3, 2020
)

Stopping and restarting a proactor event loop on windows can lead to
spurious errors logged (ConnectionResetError while reading from the
self pipe). This fixes the issue by ensuring that we don't attempt
to start multiple copies of the self-pipe reading loop.
(cherry picked from commit ea5a636)

Co-authored-by: Ben Darnell <ben@bendarnell.com>

Co-authored-by: Ben Darnell <ben@bendarnell.com>

1st1 pushed a commit that referenced this pull request

Sep 3, 2020
)

Stopping and restarting a proactor event loop on windows can lead to
spurious errors logged (ConnectionResetError while reading from the
self pipe). This fixes the issue by ensuring that we don't attempt
to start multiple copies of the self-pipe reading loop.
(cherry picked from commit ea5a636)

Co-authored-by: Ben Darnell <ben@bendarnell.com>

Co-authored-by: Ben Darnell <ben@bendarnell.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.

Follow-up to pythonGH-22017
(cherry picked from commit be435ae)

Co-authored-by: Ben Darnell <ben@bendarnell.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.

Follow-up to pythonGH-22017
(cherry picked from commit be435ae)

Co-authored-by: Ben Darnell <ben@bendarnell.com>

1st1 pushed a commit that referenced this pull request

Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.

Follow-up to GH-22017
(cherry picked from commit be435ae)

Co-authored-by: Ben Darnell <ben@bendarnell.com>

Co-authored-by: Ben Darnell <ben@bendarnell.com>

1st1 pushed a commit that referenced this pull request

Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.

Follow-up to GH-22017
(cherry picked from commit be435ae)

Co-authored-by: Ben Darnell <ben@bendarnell.com>

Co-authored-by: Ben Darnell <ben@bendarnell.com>

xzy3 pushed a commit to xzy3/cpython that referenced this pull request

Oct 18, 2020
Stopping and restarting a proactor event loop on windows can lead to
spurious errors logged (ConnectionResetError while reading from the
self pipe). This fixes the issue by ensuring that we don't attempt
to start multiple copies of the self-pipe reading loop.

xzy3 pushed a commit to xzy3/cpython that referenced this pull request

Oct 18, 2020
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.

Follow-up to pythonGH-22017

@Bogay Bogay mentioned this pull request

Sep 26, 2021

4 tasks