[3.8] bpo-41654: Explicitly cast PyExc_MemoryError to PyTypeObject to avoid warning by pablogsal · Pull Request #22102 · python/cpython

the-knights-who-say-ni

pablogsal changed the title ~~bpo-41654: Explicitly cast PyExc_MemoryError to PyTypeObject to avoid warning~~ [3.8] bpo-41654: Explicitly cast PyExc_MemoryError to PyTypeObject to avoid warning

Sep 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got another compile warning: D:\a\1\s\Objects\exceptions.c(2324,56): warning C4098: 'MemoryError_dealloc': 'void' function returning a value [D:\a\1\s\PCbuild\pythoncore.vcxproj] in here.
Maybe we can cancel return?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot cancel it, but we can split the expression so the mvsc is happy.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your update. LGTM now :)