◐ Shell
clean mode source ↗

bpo-41861: Convert _sqlite3 RowType and StatementType to heap types by erlend-aasland · Pull Request #22444 · python/cpython

Erlend E. Aasland added 2 commits

September 29, 2020 00:14

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you remove Py_TPFLAGS_HEAPTYPE.

@erlend-aasland

LGTM if you remove Py_TPFLAGS_HEAPTYPE.

See 6d22771

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erlend-aasland

@vstinner Any idea why the macOS tests are failing? I'm unable to see the details (perhaps due to a recent change in the CI?). I'm tempted to just re-run the checks.

@vstinner

@vstinner Any idea why the macOS tests are failing? I'm unable to see the details (perhaps due to a recent change in the CI?). I'm tempted to just re-run the checks.

I don't see any logs. It looks like a bug on the GitHub Action. I don't know how to debug such issue.

These checks are not mandatory, you can safely ignore it.

@vstinner

Merged, thanks. Next? :-)

@erlend-aasland

Merged, thanks. Next? :-)

Thanks, coming right up! :)

xzy3 pushed a commit to xzy3/cpython that referenced this pull request

Oct 18, 2020