bpo-41919: Move the codecs.register operation to the setup of testcases. by shihai1991 · Pull Request #22513 · python/cpython
Hi, victor. Pls take a look when you have free time. @vstinner
bpo-41919: Move the codecs.register operation to testcases.
bpo-41919: Move the codecs.register operation to the inside of testcases.
bpo-41919: Move the codecs.register operation to the inside of testcases.
bpo-41919: Move the codecs.register operation to the setup of testcases.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I checked for leaks: ./python -m test test_codecs -R 3:3 pass (no leak), good!
It seems like your PR is sick: it got two Travis CI, and one will never complete. It's a victim of python/core-workflow#377 bug.
Can you try to recreate a new PR? For example, rename your local branch update_test_codecs to update_test_codecs2 and publish it.
Or wait until python/core-workflow#377 is fixed (Travis CI made optional).
It seems like your PR is sick: it got two Travis CI, and one will never complete. It's a victim of python/core-workflow#377 bug.
Can you try to recreate a new PR? For example, rename your local branch update_test_codecs to update_test_codecs2 and publish it.
Or wait until python/core-workflow#377 is fixed (Travis CI made optional).
Copy that, I can waiting the fix of issues/377 :)
Copy that, I can waiting the fix of issues/377 :)
Travis CI is no longer mandatory.
I merged your PR, thanks.
Copy that, I can waiting the fix of issues/377 :)
Travis CI is no longer mandatory.
I merged your PR, thanks.
Wow, thanks, victor.
xzy3 pushed a commit to xzy3/cpython that referenced this pull request
…GH-22513) * Move the codecs' (un)register operation to testcases. * Remove _codecs._forget_codec() and _PyCodec_Forget()
adorilson pushed a commit to adorilson/cpython that referenced this pull request
…GH-22513) * Move the codecs' (un)register operation to testcases. * Remove _codecs._forget_codec() and _PyCodec_Forget()