◐ Shell
clean mode source ↗

bpo-41919: Avoid resource leak in test_io module by shihai1991 · Pull Request #22973 · python/cpython

the-knights-who-say-ni

Conversation

@shihai1991

Pls take a look if you have free time, Thanks. @pablogsal @vstinner
./python -m test test_io -R 3:3 -vv have passed in my local.

pablogsal

pablogsal

@pablogsal

Thanks for the investigation and for the quick fix, @shihai1991!

I can confirm that this PR indeed fixes the problem:

❯ ./python -m test test_io -R 3:3
0:00:00 load avg: 4.13 Run tests sequentially
0:00:00 load avg: 4.13 [1/1] test_io
beginning 6 repetitions
123456
......
test_io passed in 3 min 36 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 3 min 36 sec
Tests result: SUCCESS

@shihai1991

Thanks palbo for review & merge.

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021 
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

Labels