bpo-30728: IDLE: Refactor configdialog to PEP8 names and add docstrings by csabella · Pull Request #2307 · python/cpython

Thank you Cheryl for the work this involved and Louie for the non-trivial review. I did not review every change but focused on Louie's comments, as they raise a couple of meta-issues of how much to do in one patch. As a result, I have a better idea how to move forward.

This PR does not belong to #27388. That aside, I think this PR does too much at once and may be pre-mature.

After submitting this, I will open a new issue for modernizing configdialog. Modernizing includes: adding docstrings; changing to PEP8 names; changing most comments to sentences; reviewing and possibly changing overly cryptic existing PEP8 names; and at least metaphorically, adding tests. For a large file like config dialog, I would like a separate PR for each of these.

Louie's comment on config_key got me thinking again about the problem of breaking existing tracker patches, especially any that are ready to go. There were no patches that I know of for textview and I don't intend to apply the existing one for About IDLE as is.

Many of the comments below also appear above as responses to Louie's comments. Most can also be understood as they are.