bpo-29591: [2.7] Update VS project files by jkloth · Pull Request #2310 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please elaborate the commit message to list removed define and explain that they are now already defined in Modules/expat/winconfig.h?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that this change is still needed with expat 2.2.1. Would you mind to check please?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this is unrelated to just Expat. It brings the VS9.0 project files inline with the MSBuild ones. Ever wonder why the Expat change "just worked" on the other releases? ;)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok fine. I'm just surprised that we have to define it manualy. It should already be defined by <windows.h> no?