◐ Shell
clean mode source ↗

bpo-23451: Fix socket deprecation warnings in socketmodule.c by segevfiner · Pull Request #2318 · python/cpython

@zooba Oh my... I got hit by unrelated issues trying to do this... 😣

  1. Fix exception in Python 3.7 due to bad re.sub replacement escapes pytest-dev/py#125
  2. https://github.com/kiorky/SOAPpy/issues/26
  3. It seems to have an undeclared dependency on PyWin32. Yay for no PyWin32 wheels (It has a post install script which I think is the major reason it doesn't have any). Luckily they do have builds for Python 3.7 that I could install manually using easy_install.

Had to manually modify the virtualenv created by Tox to workaround these.

BTW, I also found Scripts/msi/make_zip.py which also worked if I modified it to also include .py source files.

I got the following (minus SKIPPED tests):

[FAIL]
Traceback (most recent call last):
  File "twisted\build\py-tests\lib\site-packages\twisted\web\test\test_http.py", line 1832, in test_multipartFormData
    b"HTTP/1.0 200 OK\r\n\r\ndone")
  File "twisted\build\py-tests\lib\site-packages\twisted\trial\_synctest.py", line 432, in assertEqual
    super(_Assertions, self).assertEqual(first, second, msg)
  File "twisted\py37\Lib\unittest\case.py", line 829, in assertEqual
    assertion_func(first, second, msg=msg)
  File "twisted\py37\Lib\unittest\case.py", line 822, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: b'HTTP/1.1 400 Bad Request\r\n\r\n' != b'HTTP/1.0 200 OK\r\n\r\ndone'

twisted.web.test.test_http.ParsingTests.test_multipartFormData
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "twisted\build\py-tests\lib\site-packages\twisted\logger\test\test_file.py", line 125, in test_timeFormat
    observer(dict(log_format=u"XYZZY", log_time=1.23456))
  File "twisted\build\py-tests\lib\site-packages\twisted\logger\_file.py", line 50, in __call__
    text = self.formatEvent(event)
  File "twisted\build\py-tests\lib\site-packages\twisted\logger\_file.py", line 83, in formatEvent
    event, formatTime=lambda e: formatTime(e, timeFormat)
  File "twisted\build\py-tests\lib\site-packages\twisted\logger\_format.py", line 203, in formatEventAsClassicLogText
    timeStamp = formatTime(event.get("log_time", None))
  File "twisted\build\py-tests\lib\site-packages\twisted\logger\_file.py", line 83, in <lambda>
    event, formatTime=lambda e: formatTime(e, timeFormat)
  File "twisted\build\py-tests\lib\site-packages\twisted\logger\_format.py", line 133, in formatTime
    tz = FixedOffsetTimeZone.fromLocalTimeStamp(when)
  File "twisted\build\py-tests\lib\site-packages\twisted\python\_tzhelper.py", line 86, in fromLocalTimeStamp
    datetime.fromtimestamp(timeStamp) -
builtins.OSError: [Errno 22] Invalid argument

twisted.logger.test.test_file.TextFileLogObserverTests.test_timeFormat
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "twisted\build\py-tests\lib\site-packages\twisted\logger\test\test_format.py", line 247, in test_formatTimePercentF
    self.assertEqual(formatTime(1.23456, timeFormat="%f"), u"234560")
  File "twisted\build\py-tests\lib\site-packages\twisted\logger\_format.py", line 133, in formatTime
    tz = FixedOffsetTimeZone.fromLocalTimeStamp(when)
  File "twisted\build\py-tests\lib\site-packages\twisted\python\_tzhelper.py", line 86, in fromLocalTimeStamp
    datetime.fromtimestamp(timeStamp) -
builtins.OSError: [Errno 22] Invalid argument

twisted.logger.test.test_format.TimeFormattingTests.test_formatTimePercentF
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "twisted\build\py-tests\lib\site-packages\twisted\names\test\test_server.py", line 1121, in test_sendReplyLoggingNoAnswers
    address=None)
  File "twisted\build\py-tests\lib\site-packages\twisted\names\test\test_server.py", line 224, in assertLogMessage
    [m['message'][0] for m in loggedMessages],
  File "twisted\build\py-tests\lib\site-packages\twisted\names\test\test_server.py", line 224, in <listcomp>
    [m['message'][0] for m in loggedMessages],
builtins.IndexError: tuple index out of range

twisted.names.test.test_server.DNSServerFactoryTests.test_sendReplyLoggingNoAnswers
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "twisted\build\py-tests\lib\site-packages\twisted\logger\_observer.py", line 131, in __call__
    observer(event)
  File "twisted\build\py-tests\lib\site-packages\twisted\logger\_legacy.py", line 93, in __call__
    self.legacyObserver(event)
  File "twisted\build\py-tests\lib\site-packages\twisted\python\log.py", line 555, in emit
    timeStr = self.formatTime(eventDict["time"])
  File "twisted\build\py-tests\lib\site-packages\twisted\python\log.py", line 530, in formatTime
    tzOffset = -self.getTimezoneOffset(when)
  File "twisted\build\py-tests\lib\site-packages\twisted\python\log.py", line 508, in getTimezoneOffset
    offset = datetime.utcfromtimestamp(when) - datetime.fromtimestamp(when)
builtins.OSError: [Errno 22] Invalid argument

twisted.names.test.test_server.DNSServerFactoryTests.test_sendReplyLoggingNoAnswers
twisted.names.test.test_server.DNSServerFactoryTests.test_sendReplyLoggingNoAnswers
twisted.names.test.test_server.DNSServerFactoryTests.test_sendReplyLoggingWithAnswers
twisted.names.test.test_server.DNSServerFactoryTests.test_sendReplyLoggingWithAnswers
twisted.names.test.test_server.DNSServerFactoryTests.test_sendReplyLoggingWithAnswers
twisted.names.test.test_server.DNSServerFactoryTests.test_sendReplyLoggingWithAnswers
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "twisted\build\py-tests\lib\site-packages\twisted\names\test\test_server.py", line 1146, in test_sendReplyLoggingWithAnswers
    address=None)
  File "twisted\build\py-tests\lib\site-packages\twisted\names\test\test_server.py", line 224, in assertLogMessage
    [m['message'][0] for m in loggedMessages],
  File "twisted\build\py-tests\lib\site-packages\twisted\names\test\test_server.py", line 224, in <listcomp>
    [m['message'][0] for m in loggedMessages],
builtins.IndexError: tuple index out of range

twisted.names.test.test_server.DNSServerFactoryTests.test_sendReplyLoggingWithAnswers
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "twisted\build\py-tests\lib\site-packages\twisted\python\test\test_zipstream.py", line 253, in test_extraData
    with zipstream.ChunkingZipFile(fn) as czf, czf.readfile("0") as zfe:
  File "twisted\py37\Lib\zipfile.py", line 1107, in __init__
    self._RealGetContents()
  File "twisted\py37\Lib\zipfile.py", line 1230, in _RealGetContents
    x._decodeExtra()
  File "twisted\py37\Lib\zipfile.py", line 442, in _decodeExtra
    raise BadZipFile("Corrupt extra field %04x (size=%d)" % (tp, ln))
zipfile.BadZipFile: Corrupt extra field 6568 (size=27756)

twisted.python.test.test_zipstream.ZipstreamTests.test_extraData
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "twisted\build\py-tests\lib\site-packages\twisted\test\test_log.py", line 564, in test_microsecondTimestampFormatting
    self.assertEqual("600000", self.flo.formatTime(12345.6))
  File "twisted\build\py-tests\lib\site-packages\twisted\python\log.py", line 528, in formatTime
    return datetime.fromtimestamp(when).strftime(self.timeFormat)
builtins.OSError: [Errno 22] Invalid argument

twisted.test.test_log.FileObserverTests.test_microsecondTimestampFormatting

None of them seem related to this change.