◐ Shell
clean mode source ↗

bpo-42351: Avoid error when opening header with non-UTF8 encoding by ronaldoussoren · Pull Request #23279 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ronaldoussoren

@ronaldoussoren ronaldoussoren commented

Nov 14, 2020

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

grep_headers_for() would error out when a header contained
text that cannot be interpreted as UTF-8.

https://bugs.python.org/issue42351

yan12125 reacted with thumbs up emoji
grep_headers_for() would error out when a header contained
text that cannot be interpreted as UTF-8.

@E-Paine

E-Paine commented

Nov 14, 2020

Copy link Copy Markdown

Contributor

@ronaldoussoren this fix works perfectly. Thanks!

@yan12125

Copy link Copy Markdown

Thanks this patch also fixes building python for me!

@ronaldoussoren ronaldoussoren merged commit 7a27c7e into python:master

Nov 14, 2020

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021
…thonGH-23279)

grep_headers_for() would error out when a header contained
text that cannot be interpreted as UTF-8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronaldoussoren @E-Paine @yan12125 @the-knights-who-say-ni @bedevere-bot