◐ Shell
clean mode source ↗

bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 1 of 2 by erlend-aasland · Pull Request #23341 · python/cpython

@erlend-aasland

@corona10: As proposed on #23057, I've split that PR up in two parts. This is the first, and larger (by line count) part, however probably the easiest to review, as the AC conversion is straight-forward.

This was referenced

Nov 17, 2020

@erlend-aasland

@corona10 Have you had time to look at this? Let me know if still think it's too large for a single review.

@corona10

@erlend-aasland

corona10

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland

I have made the requested changes; please review again

@bedevere-bot

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

corona10

corona10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for nit comment ;)

@erlend-aasland

LGTM except for nit comment ;)

I appreciate a thorough review! :) PTAL

serhiy-storchaka

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021