◐ Shell
clean mode source ↗

[3.9] bpo-40998: Fix a refleak in create_filter() (GH-23365) by tiran · Pull Request #23369 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tiran

@tiran tiran commented

Nov 18, 2020

•

edited by miss-islington

Loading

Copy link Copy Markdown

Member

(cherry picked from commit d1e38d4)

https://bugs.python.org/issue40998

Automerge-Triggered-By: GH:tiran

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

note: Py_INCREF() is not well indented :-)

@tiran tiran force-pushed the backport-d1e38d4-3.9 branch from ac7fa7c to fa71a0f Compare

November 18, 2020 16:19

@tiran

tiran commented

Nov 18, 2020

Copy link Copy Markdown

Member Author

note: Py_INCREF() is not well indented :-)

Ah, my editor inserted a tab. Fixed!

@miss-islington

Copy link Copy Markdown

Contributor

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot