bpo-31904: support signal module for VxWorks by pxinwr · Pull Request #23391 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to not add a new blurb category just for VxWorks. Would you mind to reuse the Library category?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine. Fixed accordingly.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to not copy/paste the code, restrict the difference to the loop. Something like:
| for chunk_size in (2 ** 16, 2 ** 8, 1): | |
| if sys.platform == "vxworks": | |
| CHUNK_SIZES = (1,) | |
| else: | |
| CHUNK_SIZES = (2 ** 16, 2 ** 8, 1) | |
| for chunk_size in CHUNK_SIZES: |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better solution. Changed.