bpo-29376: Fix assertion error in threading._DummyThread.is_alive() by zhangyangyu · Pull Request #236 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Conversation
zhangyangyu
added
type-bug
needs backport to 3.5 labels
willingc
approved these changes
willingc
left a comment
willingc
left a comment
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhangyangyu Thanks. The code looks good to me.
Leaving for a core dev to merge.
zhangyangyu
commented
Feb 22, 2017
zhangyangyu commented
Member Author
@willingc Thanks for the review.
Hmm, I am a core dev but I can't self-approve. :-/
Mariatta
added
CLA not signed
and removed
CLA not signed
labels
the-knights-who-say-ni
added
the
CLA signed
label
Mariatta
approved these changes
zhangyangyu added 2 commits
zhangyangyu
merged commit
f3a9fab
into
python:master
zhangyangyu
deleted the
bpo-29376
branch
zhangyangyu added a commit to zhangyangyu/cpython that referenced this pull request
This was referenced
zhangyangyu
removed
needs backport to 3.5
labels
jaraco added a commit to jaraco/cpython that referenced this pull request
Deprecate legacy functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment