bpo-40939: Restore some stable API functions incorrectly deleted by pablogsal · Pull Request #23606 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you also get rid of PyCompileString on line 1241? Because that's just a typo.
Shouldn't you also get rid of PyCompileString on line 1241? Because that's just a typo.
Done in 4989ebe
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you double checked that all these signatures match? (I haven't, I just trust that you know what you're doing. :-)
Have you double checked that all these signatures match?
I have restored them as they were before the removal (so they should match whatever state they were in 3.8/3.9) and then I checked that all of them appear in Include/pythonrun.h (cross-match with 343ed0f) and that the signatures are correct. :)
Sounds good then -- thanks for doing the due diligence!
