◐ Shell
clean mode source ↗

bpo-34805: Guarantee that __subclasses__() is in definition order. by rhettinger · Pull Request #23844 · python/cpython

rhettinger

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@rhettinger

@rhettinger rhettinger commented

Dec 18, 2020

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

pekkaklarck reacted with heart emoji

@pablogsal pablogsal left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhettinger rhettinger merged commit 51f4688 into python:master

Dec 19, 2020

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

Copy link Copy Markdown

GH-23850 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Dec 19, 2020 
…ythonGH-23844)

(cherry picked from commit 51f4688)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhettinger @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni