[3.8] bpo-42866: Fix refleak in CJK getcodec() (GH-24165) by miss-islington · Pull Request #24168 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Closed
Conversation
Contributor
Fix a reference leak in the getcodec() function of CJK codecs.
(cherry picked from commit e542d41)
Co-authored-by: Victor Stinner vstinner@python.org
Fix a reference leak in the getcodec() function of CJK codecs. (cherry picked from commit e542d41) Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington
commented
Jan 8, 2021
miss-islington commented
Contributor Author
@vstinner: Status check is done, and it's a success ✅ .
miss-islington
commented
Jan 8, 2021
miss-islington commented
Contributor Author
@vstinner: Status check is done, and it's a success ✅ .
vstinner
approved these changes
vstinner
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good bot.
miss-islington
commented
Jan 8, 2021
miss-islington commented
Contributor Author
@vstinner: Status check is done, and it's a failure ❌ .
vstinner
commented
Jan 8, 2021
vstinner commented
Member
Oh, getmultibytecodec() holds a reference to cofunc. My backport is wrong, sorry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
