◐ Shell
clean mode source ↗

bpo-41824: Add versionadded for typing.ForwardRef docs by Fidget-Spinner · Pull Request #24224 · python/cpython

Conversation

@Fidget-Spinner

I'm guessing this should be backported to 3.9 and 3.8 (along with skip news)?

gvanrossum

@bedevere-bot

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@Fidget-Spinner

@gvanrossum Thanks Guido! Should this be backported to 3.9/3.8 too?

@gvanrossum

@gvanrossum Thanks Guido! Should this be backported to 3.9/3.8 too?

Sure.

@Fidget-Spinner

@gvanrossum Thanks Guido! Should this be backported to 3.9/3.8 too?

Sure.

Sorry to trouble, can you add the labels for them please? I don't have permissions to. Though I'm not sure if the bot will pick it up if the label is applied after the PR is merged rather than before. Either way I'm fine with manually backporting them too.

@miss-islington

Thanks @Fidget-Spinner for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

@gvanrossum

Looks like the bot picked it up!

@miss-islington

Sorry, @Fidget-Spinner and @gvanrossum, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker da21f7b6e1fd5bd3e78931a06c5eb694f6335233 3.8

@miss-islington

Sorry @Fidget-Spinner and @gvanrossum, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker da21f7b6e1fd5bd3e78931a06c5eb694f6335233 3.9

@Fidget-Spinner

Aww I guess I should've done it manually from the start then. Thanks for the help anyways!

@bedevere-bot

Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this pull request

Feb 9, 2021

@bedevere-bot

gvanrossum pushed a commit that referenced this pull request

Feb 9, 2021

gvanrossum pushed a commit that referenced this pull request

Feb 9, 2021

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021

Labels