◐ Shell
clean mode source ↗

bpo-43244: GitHub Action builds Python in debug mode on Windows by vstinner · Pull Request #24914 · python/cpython

vstinner

@vstinner 

The debug mode catchs more bugs but is slower.

@vstinner

Oh, test_peg_generator failed. I rebased my PR on top of my commit 57d0a87 fix.

test_locale also fails, I don't know why and I don't see why it only fails in debug mode:

ERROR: test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_locale.py", line 567, in test_getsetlocale_issue1813
    locale.setlocale(locale.LC_CTYPE, loc)
  File "D:\a\cpython\cpython\lib\locale.py", line 610, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting

@vstinner

The job still fails with:

ERROR: test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_locale.py", line 567, in test_getsetlocale_issue1813
    locale.setlocale(locale.LC_CTYPE, loc)
  File "D:\a\cpython\cpython\lib\locale.py", line 610, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting

With test_locale re-run in verbose mode, "the total tests duration is 19 min 41 sec.

@vstinner

@vstinner

Without this PR (Python built in release mode), tests take 12 min 19 sec on Windows x64. It should be compared with 19 min 41 sec with this PR. So this PR adds 7 minutes to the CI, it's quite signifiant (1.6x slower).

I'm not sure that I would like to make the CI slower on all PRs just because once per year there is a bug not catched by the pre-commit PR. I close the PR.