◐ Shell
clean mode source ↗

Revert "bpo-43510: PEP 597: Accept `encoding="locale"` in binary mode." by methane · Pull Request #25108 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@methane

@methane methane commented

Mar 31, 2021

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, it sounds really weird to accept an encoding when a file is opened in binary mode. open(filename, "rb", encoding="locale") looks like a bug.

@methane methane merged commit cfa1766 into master

Mar 31, 2021

@methane methane deleted the revert-25103-binary-locale branch

March 31, 2021 09:49

@bedevere-bot

Copy link Copy Markdown

@methane: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane @bedevere-bot @vstinner @the-knights-who-say-ni