bpo-43651: Fix EncodingWarning in test_file and test_file_eintr by methane · Pull Request #25109 · python/cpython

methane

Conversation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the UTF-8 encoding :-) The "t" mode is ignored. I even propose to omit mode="r" since it's the default value, and I like to simply write open(filename) usually. Or now open(filename, encoding="utf-8").

Co-authored-by: Victor Stinner <vstinner@python.org>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bpo-43651: Fix EncodingWarning in test_file and test_file_eintr by methane · Pull Request #25109 · python/cpython

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Labels