◐ Shell
clean mode source ↗

bpo-43651: PEP 597: Fix EncodingWarning in some tests by methane · Pull Request #25142 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@methane

@methane methane commented

Apr 2, 2021

•

edited

Loading

Copy link Copy Markdown

Member

  • test__xxsubinterpreters
  • test_builtin
  • test_doctest
  • test_exceptions
  • test_opcodes
  • test_support
  • test_argparse
  • test_baseexception
  • test_bdb
  • test_bool
  • test_asdl_parser

https://bugs.python.org/issue43651

 
* test__xxsubinterpreters.py
* test_builtin.py
* test_doctest.py
* test_exceptions.py
* test_opcodes.py
* test_support.py

@methane methane requested a review from isidentical as a code owner

April 2, 2021 02:17

@methane methane merged commit 8bbfeb3 into python:master

Apr 2, 2021

@methane methane deleted the fix-tests branch

April 2, 2021 03:53

@vstinner

vstinner commented

Apr 2, 2021

Copy link Copy Markdown

Member

Oh, I tried to propose some minor coding styles changes, but then I noticed that you already merged your PR :-) No worry, the PR LGTM ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isidentical isidentical Awaiting requested review from isidentical

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane @vstinner @the-knights-who-say-ni @bedevere-bot