bpo-43510: Fix emitting EncodingWarning from _io module. by methane · Pull Request #25146 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Conversation
Member
I forget to check PyErr_WarnEx() return value. But it will fail when -Werror is used.
I forget to check PyErr_WarnEx() return value. But it will fail when -Werror is used.
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
methane
added
skip news
type-bug
and removed awaiting core review labels
vstinner
approved these changes
vstinner
left a comment
vstinner
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I didn't test your change.
bedevere-bot
added
the
awaiting merge
label
methane
merged commit
bec8c78
into
python:master
methane
deleted the
fix-textio-encodingwarning
branch
bedevere-bot
removed
the
awaiting merge
label
sthagen added a commit to sthagen/python-cpython that referenced this pull request
bpo-43510: Fix emitting EncodingWarning from _io module. (pythonGH-25146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment