◐ Shell
clean mode source ↗

bpo-43510: Fix emitting EncodingWarning from _io module. by methane · Pull Request #25146 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@methane

@methane methane commented

Apr 2, 2021

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

I forget to check PyErr_WarnEx() return value. But it will fail when -Werror is used.

https://bugs.python.org/issue43510

I forget to check PyErr_WarnEx() return value. But it will fail when -Werror is used.

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't test your change.

@methane methane merged commit bec8c78 into python:master

Apr 2, 2021

@methane methane deleted the fix-textio-encodingwarning branch

April 2, 2021 08:39

sthagen added a commit to sthagen/python-cpython that referenced this pull request

Apr 2, 2021
bpo-43510: Fix emitting EncodingWarning from _io module. (pythonGH-25146)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news type-bug

An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane @vstinner @the-knights-who-say-ni @bedevere-bot