bpo-43725: Add CI step to check changes in the exported ABI by pablogsal · Pull Request #25188 · python/cpython

the-knights-who-say-ni

pablogsal changed the title ~~Add CI step to check changes in the exported ABI~~ bpo-43725: Add CI step to check changes in the exported ABI

Apr 4, 2021

Unfortunately seems that doing this check with two different compiler versions produce some different DWARF and the tool identifies the differences as errors :(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, lets try it out! I suppose this shows up as a non-blocking check by default? Release branch owners can presumably decide if this is reliable enough to make it blocking.

I will try to investigate how to overcome this:

Unfortunately seems that doing this check with two different compiler versions produce some different DWARF and the tool identifies the differences as errors :(


		check_abi:
		name: 'Check if the ABI has changed'
		runs-on: ubuntu-latest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd pin the runner, to ensure that the job runs with at least the same major GCC version every time. Ref. bpo-43382.