◐ Shell
clean mode source ↗

bpo-43795: Sort PC/python3dll.c by encukou · Pull Request #25312 · python/cpython

Conversation

@encukou

Each section is sorted to reduce diffs (review effort) when the file becomes generated (PEP 652)
Sort is done with key=str.lower to preserve most of the original order (underscored items first).

https://bugs.python.org/issue43795

Each section is sorted to reduce diffs (review effort) when the file
becomes generated.
Sort is done with key=str.lower to preserve most of the original order
(underscored items first).

@encukou

I'm putting this up as a separate PR to reduce conflicts. Discussions on the main PEP 652 PR might take a while.

zware

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the file mode was changed; was that intentional? Otherwise looks good to me :)

pablogsal

I have no idea why that changed...

@encukou

I have no idea how I managed to change the mode. Thanks for the catch!

Labels