◐ Shell
clean mode source ↗

[3.9] Revert "[3.9] bpo-43725: Add ignore file for the abidump check" by pablogsal · Pull Request #25394 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@pablogsal

@pablogsal pablogsal commented

Apr 13, 2021

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@pablogsal pablogsal changed the title Revert "[3.9] bpo-43725: Add ignore file for the abidump check" [3.9] Revert "[3.9] bpo-43725: Add ignore file for the abidump check"

Apr 13, 2021

@vstinner

Copy link Copy Markdown

Member

_Py_M__importlib_bootstrap_external should be ignored explictly, no? See: https://bugs.python.org/issue43725#msg390660

@pablogsal

Copy link Copy Markdown

Member Author

_Py_M__importlib_bootstrap_external should be ignored explictly, no? See: https://bugs.python.org/issue43725#msg390660

That is only for 3.8

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we need to manually ignore symbols tomorrow, we can add again the ignorefile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @vstinner @the-knights-who-say-ni @bedevere-bot