◐ Shell
clean mode source ↗

bpo-43651: Fix EncodingWarning in tests. by methane · Pull Request #25655 · python/cpython

methane

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@methane

@methane methane commented

Apr 27, 2021

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

  • test_httplib
  • test_httpservers
  • test_logging

https://bugs.python.org/issue43651

 
* test_httplib
* test_httpservers
* test_logging

@methane methane requested a review from vsajip as a code owner

April 27, 2021 08:38

@bedevere-bot bedevere-bot added tests

Tests in the Lib/test dir

awaiting core review labels

Apr 27, 2021

@methane methane merged commit fa51c0c into python:master

Apr 29, 2021

@methane methane deleted the fix-tests branch

April 29, 2021 02:34
Comment thread

Lib/test/test_logging.py


with self.check_no_resource_warning():
#with self.check_no_resource_warning():
if 1:

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the significance of this change?

Copy link Copy Markdown

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a mistake. Nice catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip left review comments

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane @vsajip @the-knights-who-say-ni @bedevere-bot