◐ Shell
clean mode source ↗

[3.9] bpo-43961: Fix test_logging.test_namer_rotator_inheritance() (GH-25684) by miss-islington · Pull Request #25688 · python/cpython

miss-islington

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

Apr 28, 2021

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Fix test_logging.test_namer_rotator_inheritance() on Windows: use
os.replace() rather than os.rename().
(cherry picked from commit fe52eb6)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue43961

 
…H-25684)

Fix test_logging.test_namer_rotator_inheritance() on Windows: use
os.replace() rather than os.rename().
(cherry picked from commit fe52eb6)

Co-authored-by: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner vstinner merged commit 629ef0f into python:3.9

Apr 28, 2021

@miss-islington miss-islington deleted the backport-fe52eb6-3.9 branch

April 28, 2021 15:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees

No one assigned

Labels

tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot