◐ Shell clean mode source ↗

bpo-43795 - Update Stable ABI dat. by orsenthil · Pull Request #25716 · python/cpython

the-knights-who-say-ni

Conversation

PRs were failing with the check if generated files are up to date. For e.g this one.

The Stable ABI was updated here in this PR - #25315
The change in this diff was introduced here - 3cc481b

I had run make regen-limited-abi to recrete the stable abi manifest.

https://bugs.python.org/issue43774

orsenthil changed the title ~~Update Stable ABI dat.~~ bpo-43774 - Update Stable ABI dat.

		PyFrozenSet_New
		PyFrozenSet_Type
		PyGC_Collect
		PyGC_Disable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right to me and don't know how to read this.

This was the output of make regen-limited-abi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@encukou - Please verify if this is correct.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's not correct. Those should stay in the file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They probably need to get added to Misc/stable_abi.txt now. That seems to be the new source of truth. I'll add them there.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scoder - Thank you. I could update this PR with Misc/stable_abi.txt change too.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petr took care of it - #25720

orsenthil changed the title ~~bpo-43774 - Update Stable ABI dat.~~ bpo-43795 - Update Stable ABI dat.

Oh, these are new symbols that got in as I merged PEP 652 commit. Sorry for the mismatch; I'll add them.
Details are in PEP 652, while I'm finishing up proper docs.

Updating this PR at the correct location.

Thank you. This is resolved by #25720