◐ Shell
clean mode source ↗

bpo-43933: Show frame.f_lineno as None, rather than -1, if there is no line number. by markshannon · Pull Request #25717 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@markshannon

@markshannon markshannon commented

Apr 29, 2021

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

As specified by PEP 626.
This should not be observable unless frame.f_trace_opcodes is set, or some other oddity.

https://bugs.python.org/issue43933

@markshannon markshannon force-pushed the present-none-if-missing-lineno branch from 046b8ae to 9bd0186 Compare

April 29, 2021 13:07

@encukou

encukou commented

Apr 29, 2021

Copy link Copy Markdown

Member

The "Check if generated files are up to date" test is failing because of unfortunate timing when merging other PRs (GH-25315, GH-25687).
It's OK to ignore it. Sorry for the inconvenience.

@markshannon markshannon reopened this

Apr 29, 2021

@markshannon markshannon merged commit 088a15c into python:master

Apr 29, 2021

@markshannon markshannon deleted the present-none-if-missing-lineno branch

May 4, 2021 09:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markshannon @encukou @the-knights-who-say-ni @bedevere-bot