◐ Shell
clean mode source ↗

bpo-44047: Remove unused statement argument to _pysqlite_seterror by erlend-aasland · Pull Request #25915 · python/cpython

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@orsenthil

This looks good to me.

  • Is there a way to exercise this change? (Is there is a need to exercise this change via demo that things will continue to work?)

@erlend-aasland

  • Is there a way to exercise this change? (Is there is a need to exercise this change via demo that things will continue to work?)

I'll have a look at the coverage report from the test suite in a couple of hours. I'll see if it is possible to squeeze out a couple more corner cases. (Stuff like memory errors is of course hard to do, but not impossible.) I'll keep you posted :)

berkerpeksag

@berkerpeksag

@erlend-aasland

Thanks for reviewing, both of you!

Labels