◐ Shell
clean mode source ↗

bpo-44116: Work around module unloading refleak to unblock buildbots by encukou · Pull Request #26068 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@encukou

@encukou encukou commented

May 12, 2021

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

The csv and urllib.request modules leak references when unloaded using test.support.import_helper.modules_cleanup().
This should unblock refleak buildbots while the issue is investigated.

https://bugs.python.org/issue44116

@bedevere-bot bedevere-bot added the tests

Tests in the Lib/test dir

label

May 12, 2021

@encukou encukou added the 🔨 test-with-buildbots

Test PR w/ buildbots; report in status section

label

May 12, 2021

@bedevere-bot

Copy link Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit d4f5910 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots

Test PR w/ buildbots; report in status section

label

May 12, 2021

@erlend-aasland

Copy link Copy Markdown

Contributor

Is this still needed?

@encukou

encukou commented

May 12, 2021

Copy link Copy Markdown

Member Author

I don't think it is. Thank you for fixing it thoroughly!

@encukou encukou closed this

May 12, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@encukou @bedevere-bot @erlend-aasland @the-knights-who-say-ni