bpo-43988: Use check disallow instantiation helper by erlend-aasland · Pull Request #26392 · python/cpython
Erlend E. Aasland added 2 commits
bpo-43988: Use check disallow instantiation
bpo-43988: Use check disallow instantiation helper
Erlend E. Aasland added 3 commits
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to avoid tp = ... and then use tp, since "tp" name doesn't help: use directly "...". I wrote some examples.
Merged, thanks. This helper makes me more confident that the test actually checks that the type is immutable.
Merged, thanks. This helper makes me more confident that the test actually checks that the type is immutable.
Great, thanks for reviewing and improving the PR!
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request