◐ Shell
clean mode source ↗

[3.10] bpo-42161: mathmodule.c: move _PyLong_GetOne() loop invariant (GH-26391) by miss-islington · Pull Request #26393 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

May 26, 2021

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Move _PyLong_GetZero() and _PyLong_GetOne() loop invariants outside
loops in functions:

  • math.comb()
  • math.gcd()
  • math.lcm()
  • math.perm()
    (cherry picked from commit 3e7ee02)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue42161

 
…GH-26391)

Move _PyLong_GetZero() and _PyLong_GetOne() loop invariants outside
loops in functions:

* math.comb()
* math.gcd()
* math.lcm()
* math.perm()
(cherry picked from commit 3e7ee02)

Co-authored-by: Victor Stinner <vstinner@python.org>

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner vstinner merged commit 4115996 into python:3.10

May 26, 2021

@miss-islington miss-islington deleted the backport-3e7ee02-3.10 branch

May 26, 2021 23:13

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ❌ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot