[3.10] bpo-42972: Fully implement GC protocol for re types (GH-26368) by miss-islington · Pull Request #26411 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Closed
Conversation
Contributor
(cherry picked from commit fba42d1)
Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no
(cherry picked from commit fba42d1) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington
commented
May 27, 2021
miss-islington commented
Contributor Author
@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .
miss-islington
commented
May 27, 2021
miss-islington commented
Contributor Author
@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .
vstinner
approved these changes
vstinner
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good bot.
miss-islington
commented
May 27, 2021
miss-islington commented
Contributor Author
@erlend-aasland and @vstinner: Status check is done, and it's a failure ❌ .
vstinner
commented
May 27, 2021
vstinner commented
Member
Tests / Windows (x64) (pull_request) Failing
It failed because of: https://bugs.python.org/issue44252#msg394581
I re-run the job.
vstinner
commented
May 27, 2021
vstinner commented
Member
Problem 2: I had to cancel the Ubuntu job after 1 hour since downloading the ccache never completed.
Problem 3: I cannot re-run all jobs, the GitHub UI only offers me [cancel workflow] choice. I closed the PR, I will recreate it instead. Let's hope that https://bugs.python.org/issue44252#msg394581 doesn't occur again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
