[3.10] bpo-42972: Fully implement GC protocol for functools LRU cache (GH-26423) by miss-islington · Pull Request #26425 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Merged
Conversation
Contributor
(cherry picked from commit 3f8d332)
Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no
…nGH-26423) (cherry picked from commit 3f8d332) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington
requested a review
from rhettinger
as a code owner
the-knights-who-say-ni
added
the
CLA signed
label
miss-islington
commented
May 28, 2021
miss-islington commented
Contributor Author
@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .
bedevere-bot
mentioned this pull request
bedevere-bot
added
skip news
awaiting review
labels
vstinner
approved these changes
vstinner
left a comment
vstinner
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good bot.
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
miss-islington
commented
May 28, 2021
miss-islington commented
Contributor Author
@erlend-aasland and @vstinner: Status check is done, and it's a success ❌ .
miss-islington
commented
May 28, 2021
miss-islington commented
Contributor Author
@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .
miss-islington
commented
May 28, 2021
miss-islington commented
Contributor Author
Sorry, I can't merge this PR. Reason: 2 of 5 required status checks are expected..
vstinner
commented
May 28, 2021
vstinner commented
Member
Windows (x64) failed with: https://bugs.python.org/issue44252
test_host_port (test.test_httplib.HTTPSTest) ... ok
Windows fatal exception: access violation
...
I re-run the CI jobs.
miss-islington
commented
May 28, 2021
miss-islington commented
Contributor Author
@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .
miss-islington
merged commit
1c0106c
into
python:3.10
bedevere-bot
removed
the
awaiting merge
label
miss-islington
deleted the
backport-3f8d332-3.10
branch
vstinner
mentioned this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment