bpo-42213: Check connection in sqlite3.Connection.__enter__ by erlend-aasland · Pull Request #26512 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Conversation
- add tests that exercise operations against a closed database
- add utility wrapper for sqlite3_close_v2()
- add connection sanity check on
__enter__ - simplify error handling; sqlite3_close_v2() always returns SQLITE_OK
- add tests that exercise stuff against a closed database - add wrapper for sqlite3_close_v2() - check connection on __enter__ - explicitly free pending statements before close() - sqlite3_close_v2() always returns SQLITE_OK
bpo-42213: Refactor sqlite3 connection close
bpo-42213: Check connection in sqlite3.Connection.__enter__
Merged, this change is atomic and remains useful, thanks!
Thanks for reviewing, Victor!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters