◐ Shell
clean mode source ↗

[3.10] bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows (GH-26502) by miss-islington · Pull Request #26518 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

Jun 3, 2021

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.
(cherry picked from commit ea0210f)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue43921

…26502)

Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.
(cherry picked from commit ea0210f)

Co-authored-by: Victor Stinner <vstinner@python.org>

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot added awaiting review tests

Tests in the Lib/test dir

labels

Jun 3, 2021

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner vstinner merged commit d2ab15f into python:3.10

Jun 3, 2021

@miss-islington miss-islington deleted the backport-ea0210f-3.10 branch

June 3, 2021 20:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees

No one assigned

Labels

tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot