bpo-43693: Un-revert commits 2c1e258 and b2bf2bc. by ericsnowcurrently · Pull Request #26577 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
merged 2 commits into
Merged
Conversation
Member
These were reverted in gh-26530 (commit 17c4edc) due to refleaks.
- 2c1e258 - Compute deref offsets in compiler (bpo-43693: Compute deref offsets in compiler #25152)
- b2bf2bc - Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (bpo-43693: Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. #26388)
This PR fixes the refleaks. (@pablogsal, I'm running it through the buildbots before merging this time.)
ericsnowcurrently
requested review from
markshannon and
tiran
as code owners
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
ericsnowcurrently
removed the request for review
from tiran
ericsnowcurrently
added
the
🔨 test-with-buildbots
label
bedevere-bot
commented
Jun 7, 2021
bedevere-bot commented
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 4eb1135e930dcea94483d350ac5ed92ee07f22ae 🤖
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
bedevere-bot
removed
the
🔨 test-with-buildbots
label
pablogsal
commented
Jun 7, 2021
pablogsal commented
Member
This PR fixes the refleaks. (@pablogsal, I'm running it through the buildbots before merging this time.)
Thanks a lot @ericsnowcurrently ❤️
ericsnowcurrently added 2 commits
These were reverted in pythonGH-26530 (commit 17c4edc). * Compute deref offsets in compiler (pythongh-25152) * Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (pythongh-26388)
ericsnowcurrently
force-pushed
the
unrevert-localsplusnames
branch
from
4eb1135 to
1fb813c
Compare
ericsnowcurrently
commented
Jun 7, 2021
ericsnowcurrently commented
Member Author
The buildbots say "the refleaks have been fixed". 🙂
ericsnowcurrently
merged commit
2ab27c4
into
python:main
bedevere-bot
removed
the
awaiting core review
label
ericsnowcurrently
deleted the
unrevert-localsplusnames
branch
markshannon
mentioned this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment