◐ Shell
clean mode source ↗

bpo-43693: Un-revert commits 2c1e258 and b2bf2bc. by ericsnowcurrently · Pull Request #26577 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented

Jun 7, 2021

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

These were reverted in gh-26530 (commit 17c4edc) due to refleaks.

This PR fixes the refleaks. (@pablogsal, I'm running it through the buildbots before merging this time.)

https://bugs.python.org/issue43693

@ericsnowcurrently ericsnowcurrently removed the request for review from tiran

June 7, 2021 15:24

@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots

Test PR w/ buildbots; report in status section

label

Jun 7, 2021

@bedevere-bot

Copy link Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 4eb1135e930dcea94483d350ac5ed92ee07f22ae 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots

Test PR w/ buildbots; report in status section

label

Jun 7, 2021

@pablogsal

Copy link Copy Markdown

Member

This PR fixes the refleaks. (@pablogsal, I'm running it through the buildbots before merging this time.)

Thanks a lot @ericsnowcurrently ❤️

These were reverted in pythonGH-26530 (commit 17c4edc).

* Compute deref offsets in compiler (pythongh-25152)
* Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (pythongh-26388)

@ericsnowcurrently ericsnowcurrently force-pushed the unrevert-localsplusnames branch from 4eb1135 to 1fb813c Compare

June 7, 2021 18:04

@ericsnowcurrently

Copy link Copy Markdown

Member Author

The buildbots say "the refleaks have been fixed". 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericsnowcurrently @bedevere-bot @pablogsal @the-knights-who-say-ni