bpo-43693: Un-revert commit f3fa63e. by ericsnowcurrently · Pull Request #26609 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
merged 3 commits into
Merged
Conversation
Member
This was reverted in GH-26596 (commit 6d518bb) due to some bad memory accesses.
- Add the MAKE_CELL opcode. (bpo-43693: Add the MAKE_CELL opcode and interleave fast locals offsets. #26396)
The memory accesses have been fixed and I verified the address sanitizer is happy now (after duplicating the failure locally).
ericsnowcurrently added 3 commits
…cals offsets. (pythongh-26396)" That commit (3fe921c) was reverted in pythonGH-26597 (3fe921c).
label
bedevere-bot
commented
Jun 8, 2021
bedevere-bot commented
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5107da7 🤖
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
label
pablogsal
approved these changes
pablogsal
commented
Jun 8, 2021
pablogsal commented
Member
Thanks for the quick fix, @ericsnowcurrently
3e1c716
into
python:main
bedevere-bot
commented
Jun 8, 2021
bedevere-bot commented
@ericsnowcurrently: Please replace # with GH- in the commit message next time. Thanks!
ericsnowcurrently added a commit that referenced this pull request
This is the same fix as for PyFrame_LocalsToFast() in gh-26609, but applied to PyFrame_FastToLocalsWithError(). (It should have been in that PR.) https://bugs.python.org/issue43693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
