◐ Shell
clean mode source ↗

bpo-43693: Do not check co_cell2arg if a non-cell offset. by ericsnowcurrently · Pull Request #26626 · python/cpython

ericsnowcurrently

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented

Jun 9, 2021

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

This is the same fix as for PyFrame_LocalsToFast() in gh-26609, but applied to PyFrame_FastToLocalsWithError(). (It should have been in that PR.)

https://bugs.python.org/issue43693
gvanrossum reacted with thumbs up emoji

@markshannon

Copy link Copy Markdown

Member

@ericsnowcurrently have you run the tests with the address sanitizer on this?

@ericsnowcurrently

Copy link Copy Markdown

Member Author

@markshannon, I did not. However, I figured this would take care of the problem and the buildbot results for the merge indicate it did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericsnowcurrently @markshannon @the-knights-who-say-ni @bedevere-bot